Skip to content

bench: update random value generation #7010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2025
Merged

bench: update random value generation #7010

merged 3 commits into from
May 18, 2025

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented May 15, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the stats/base/dists/chi/* packages.
  • Replaces uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Updates the test messages to follow code conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels May 15, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented May 15, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/chi/mode $\color{green}162/162$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}162/162$
$\color{green}+100.00\%$
stats/base/dists/chi/pdf $\color{green}236/236$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}236/236$
$\color{green}+100.00\%$
stats/base/dists/chi/quantile $\color{green}198/198$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}198/198$
$\color{green}+100.00\%$
stats/base/dists/chi/skewness $\color{green}114/114$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}114/114$
$\color{green}+100.00\%$
stats/base/dists/chi/stdev $\color{green}165/165$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}165/165$
$\color{green}+100.00\%$
stats/base/dists/chi/variance $\color{green}164/164$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}164/164$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented May 16, 2025

@hrshya Mind addressing the lint error and CI failures? Thanks!

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels May 16, 2025
hrshya added 2 commits May 16, 2025 11:38
@hrshya
update benchmark.js
6c164eb 
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
@hrshya
update benchmark.native.js
8c95093 
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
Planeshifter
Planeshifter approved these changes May 18, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 18, 2025
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label May 18, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

bench: update random value generation

PR-URL: https://github.com/stdlib-js/stdlib/pull/7010

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit b51a457 into stdlib-js:develop May 18, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrshya @stdlib-bot @kgryte @Planeshifter